From b797a282f5f40e8d913929fcff52400476c67728 Mon Sep 17 00:00:00 2001 From: Hannah-Dagemark Date: Mon, 4 Dec 2023 08:56:18 +0100 Subject: [PATCH] Minor changes for comment issues --- lib/Request.rb | 12 +++++------- lib/route.rb | 0 spec/spec_helper.rb | 2 +- testing.rb | 10 +++++----- 4 files changed, 11 insertions(+), 13 deletions(-) create mode 100644 lib/route.rb diff --git a/lib/Request.rb b/lib/Request.rb index daf0f15..2476327 100644 --- a/lib/Request.rb +++ b/lib/Request.rb @@ -3,15 +3,12 @@ class Request def initialize(input) @input = input - @method = "" - @resource = "" - @version = "" - @headers = [] - @params = [] - deconstructor(@input) + variable_definer(@input) end - def deconstructor(input) + private + + def variable_definer(input) ##Defines required class variables by splitting up the input text rows = input.split(/\n/) @method, @resource, @version = rows[0].split(' ') @headers, @params = {}, {} @@ -28,6 +25,7 @@ class Request resource_deconstructor end end + def header_constructor(rows, limit) for row in rows[1..limit-1] context, information = row.split(' ') diff --git a/lib/route.rb b/lib/route.rb new file mode 100644 index 0000000..e69de29 diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 8c0ac88..d50734d 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1 +1 @@ -require 'minitest/autorun' \ No newline at end of file +require "minitest/autorun" \ No newline at end of file diff --git a/testing.rb b/testing.rb index 8306cc9..433babf 100644 --- a/testing.rb +++ b/testing.rb @@ -1,6 +1,6 @@ -require_relative 'main' +require_relative 'lib/request' -request_string = File.read('testcases/get-index.request.txt') +request_string = File.read('spec/example_requests/get-index.request.txt') request = Request.new(request_string) @@ -10,7 +10,7 @@ p request.version p request.headers p request.params -request_string = File.read('testcases/get-examples.request.txt') +request_string = File.read('spec/example_requests/get-examples.request.txt') request = Request.new(request_string) @@ -20,7 +20,7 @@ p request.version p request.headers p request.params -request_string = File.read('testcases/get-fruits-with-filter.request.txt') +request_string = File.read('spec/example_requests/get-fruits-with-filter.request.txt') request = Request.new(request_string) @@ -30,7 +30,7 @@ p request.version p request.headers p request.params -request_string = File.read('testcases/post-login.request.txt') +request_string = File.read('spec/example_requests/post-login.request.txt') request = Request.new(request_string)